search

root-project / root-docker

Docker recipes for ROOT
30 stars 33 forks source link

update to ubuntu18 #7

Closed cburgard closed 4 years ago

cburgard commented 4 years ago

This PR updates the Dockerfile and package list of the ROOT ubuntu docker build to ubuntu18, updating some of the package names and CMake options. Also, a few very commonly used packages have been added to make this container more useful usage as a CI base image for ROOT-based projects.

kgizdov commented 4 years ago

Some improvement suggestions:

cburgard commented 4 years ago

Some improvement suggestions:

  • Combine the two RUN commands. This will save you lots of space and time, both for building the image and for using it.
  • It's strange that you build the master. You are risking build failures, breaking changes, bugs and undefined behaviour depending on when the Docker image is created. It would be better if you download the latest release - either add cd /usr/src/root && git checkout v{some-release} && cd /tmp or as {some-release}.tar.gz. This will make the Docker image consistent and more useful to your users.

Both of these comments also affect the original state of the Dockerfile before my changes, so I suppose @amadio needs to comment on these.

amadio commented 4 years ago

Combining the RUN commands is a good idea, same for fixing a version (or using a parameter for it). I originally meant these files only as simple examples, but making them follow better practices is always welcome!

xaratustrah commented 4 years ago

Hi. Just wanted to ask, what is the status of ubuntu-root on docker? Currently if I just clone and build with docker build -t myroot . (docker on OSX Catalina), I get several errors on CMAKE level, and build stops. e.g.:

Could NOT find ZSTD (missing: ZSTD_LIBRARY

if I put the libzstd-dev in the package list, then a new error comes:

Could NOT find xxHash

I am interested in an ubuntu image with python3 support and PyROOT, with FitPanel plug-in enabled. For example the docker image rootproject/root has pyhton3 support, but is missing the FitPanel plug-in. I need to add cuda support for GPU, that's the main motivation for an ubuntu based root image.

many thanks

cburgard commented 4 years ago

I was suffering from the same problem, which is why I added libxxhash-dev

xaratustrah commented 4 years ago

I was suffering from the same problem, which is why I added libxxhash-dev

Thanks, but we I try to build your Dockerfile, but I get the following error:

E: The repository 'http://security.ubuntu.com/ubuntu cosmic-security Release' does not have a Release file. if I replace ubuntu:18.10 to just ubuntu then I get:

E: Unable to locate package libxxhash-dev

it seems not be in the current ubuntu repository.

amadio commented 4 years ago

Superseded by #11. Closing.