search

root-project / root-docker

Docker recipes for ROOT
30 stars 33 forks source link

Update conda version to 6.20 #9

Closed henryiii closed 4 years ago

henryiii commented 4 years ago

Can you also please tag with the ROOT version (also include latest)?

amadio commented 4 years ago

The conda image failed to build with the error below:

Cloning into '.'...
Switched to a new branch 'patch-1'
Pulling cache layers for index.docker.io/rootproject/root-conda:latest...
Done!
KernelVersion: 4.4.0-1060-aws
Components: [{u'Version': u'18.03.1-ee-3', u'Name': u'Engine', u'Details': {u'KernelVersion': u'4.4.0-1060-aws', u'Os': u'linux', u'BuildTime': u'2018-08-30T18:42:30.000000000+00:00', u'ApiVersion': u'1.37', u'MinAPIVersion': u'1.12', u'GitCommit': u'b9a5c95', u'Arch': u'amd64', u'Experimental': u'false', u'GoVersion': u'go1.10.2'}}]
Arch: amd64
BuildTime: 2018-08-30T18:42:30.000000000+00:00
ApiVersion: 1.37
Platform: {u'Name': u''}
Version: 18.03.1-ee-3
MinAPIVersion: 1.12
GitCommit: b9a5c95
Os: linux
GoVersion: go1.10.2
Starting build of index.docker.io/rootproject/root-conda:this...
Step 1/4 : FROM continuumio/miniconda3:4.7.2
manifest for continuumio/miniconda3:4.7.2 not found
henryiii commented 4 years ago

Is it possible to manually tag the latest image as 6.20.0 after it's pushed to dockerhub using the web interface? I don't see an obvious way to do that...

PS: I see there's a 6.18.04 tag, very nice! However, it seems that tag is newer than latest, which is odd.

henryiii commented 4 years ago

I guess there's no way to publicly see the in-progress/PR builds? https://hub.docker.com/r/rootproject/root-conda/builds

amadio commented 4 years ago

Sorry, GitHub messed up authorship upon squashing this via the web interface...

henryiii commented 4 years ago

Thanks! It's okay about the authorship. Can you tag latest as 6.20 on dockerhub? I'd like to start using it in some CI tests.

amadio commented 4 years ago

Sure, I will make a tag.

chrisburr commented 4 years ago

Can you rebuild the image first? There is was a bug that broke using RDF + numpy

amadio commented 4 years ago

Can you elaborate? How will rebuild help if it's the same stuff? Was it fixed elsewhere in conda?

chrisburr commented 4 years ago

It's a bug in the conda-package itself (_rdf_utils.py is missing from pythonX.Y/site-packages so AsNumpy is fails with an ImportError).

I fixed it in https://github.com/conda-forge/root-feedstock/pull/79/ and it was deployed just over an hour ago.

amadio commented 4 years ago

Images should be all updated now. Let me know if you have any problems with them.

chrisburr commented 4 years ago

Sorry for the trouble but it looks like the layer was cached from a build which happened at around 1am.

The problematic builds end in _0 vs the update which end in _1:

$ conda list | grep root
root                      6.20.0           py37h97dbdcd_0    conda-forge
root-binaries             6.20.0           py37h97dbdcd_0    conda-forge
root-dependencies         6.20.0           py37h97dbdcd_0    conda-forge
root_base                 6.20.0           py37hedd1b78_0    conda-forge

Or to test the bug explicitly:

ipython -c "import ROOT; ROOT.ROOT.EnableImplicitMT(); rdf = ROOT.RDataFrame('DecayTree', 'root://eospublic.cern.ch//eos/opendata/lhcb/AntimatterMatters2017/data/B2HHH_MagnetUp.root'); print(rdf.Cache('H1_PX').AsNumpy())"
amadio commented 4 years ago

I messed up the tagging (tag 6.18 got rebuilt from master, making it install ROOT 6.20...). I changed the configuration now and relaunched builds. Let's see how it goes, hopefully the image will take the newer build now.