search

root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically
https://root.cern
Other
2.63k stars 1.25k forks source link

Test failures on s390x #10409

Open ellert opened 2 years ago

ellert commented 2 years ago

Describe the bug

When running the unit tests on s390x there are several failures:

97% tests passed, 34 tests failed out of 1232
Label Time Summary:
longtest               = 572.89 sec*proc (27 tests)
multithreaded          = 889.21 sec*proc (2 tests)
python_runtime_deps    =  58.00 sec*proc (11 tests)
tutorial               = 4391.45 sec*proc (786 tests)
Total Test time (real) = 2976.41 sec
The following tests FAILED:
     16 - pyunittests-pyroot-pyz-stl-vector (Failed)
     57 - pyunittests-pyroot-pyz-rtensor (Failed)
    213 - gtest-roofit-histfactory-test-testHistFactory (Failed)
    219 - gtest-roofit-roofit-test-testRooCrystalBall (Failed)
    220 - gtest-roofit-roofit-test-testRooJohnson (Failed)
    223 - gtest-roofit-roofit-test-testSumW2Error (Failed)
    228 - gtest-roofit-roofitcore-test-testRooBinSamplingPdf (Failed)
    229 - gtest-roofit-roofitcore-test-testRooSimPdfBuilder (Failed)
    230 - gtest-roofit-roofitcore-test-testRooWrapperPdf (Failed)
    231 - gtest-roofit-roofitcore-test-testRooFitDriver (Failed)
    233 - gtest-roofit-roofitcore-test-testRooAbsPdf (Failed)
    237 - gtest-roofit-roofitcore-test-testRooProdPdf (Failed)
    241 - gtest-roofit-roofitcore-test-testTestStatistics (Failed)
    242 - gtest-roofit-roofitcore-test-testRooProductPdf (Failed)
    243 - gtest-roofit-roofitcore-test-testNaNPacker (Failed)
    244 - gtest-roofit-roofitcore-test-testRooSimultaneous (Failed)
    245 - gtest-roofit-roofitcore-test-testRooGradMinimizerFcn (Failed)
    247 - gtest-roofit-roofitcore-test-testLikelihoodSerial (Failed)
    248 - gtest-roofit-roofitcore-test-testRooRealL (Failed)
    249 - gtest-roofit-roofitcore-test-testGlobalObservables (Failed)
    252 - gtest-roofit-roostats-test-testSPlot (Failed)
    274 - test-stresshistogram (Failed)
    275 - test-stresshistogram-interpreted (Failed)
    296 - test-stresshistofit (Failed)
    297 - test-stresshistofit-interpreted (Failed)
    396 - gtest-tree-dataframe-test-datasource-ntuple (Failed)
    402 - gtest-tree-ntuple-v7-test-ntuple-basics (Failed)
    406 - gtest-tree-ntuple-v7-test-ntuple-merger (Failed)
    412 - gtest-tree-ntuple-v7-test-ntuple-serialize (Failed)
    420 - gtest-tree-ntuple-v7-test-ntuple-minifile (Failed)
    423 - gtest-tree-ntuple-v7-test-ntuple-extended (Failed)
    870 - tutorial-roofit-rf612_recoverFromInvalidParameters (Failed)
    1077 - tutorial-dataframe-df006_ranges-py (Failed)
    1106 - tutorial-math-exampleFunction-py (Failed)
Errors while running CTest

With the proposed change in #10303 to not fail on the warning about RooNaNPacker not being implemented for big endian, the list of failures is shorter:

99% tests passed, 17 tests failed out of 1232
Label Time Summary:
longtest               = 540.69 sec*proc (27 tests)
multithreaded          = 678.83 sec*proc (2 tests)
python_runtime_deps    =  60.39 sec*proc (11 tests)
tutorial               = 3802.05 sec*proc (786 tests)
Total Test time (real) = 2732.59 sec
The following tests FAILED:
     16 - pyunittests-pyroot-pyz-stl-vector (Failed)
     57 - pyunittests-pyroot-pyz-rtensor (Failed)
    237 - gtest-roofit-roofitcore-test-testRooProdPdf (Failed)
    243 - gtest-roofit-roofitcore-test-testNaNPacker (Failed)
    274 - test-stresshistogram (Failed)
    275 - test-stresshistogram-interpreted (Failed)
    296 - test-stresshistofit (Failed)
    297 - test-stresshistofit-interpreted (Failed)
    396 - gtest-tree-dataframe-test-datasource-ntuple (Failed)
    402 - gtest-tree-ntuple-v7-test-ntuple-basics (Failed)
    406 - gtest-tree-ntuple-v7-test-ntuple-merger (Failed)
    412 - gtest-tree-ntuple-v7-test-ntuple-serialize (Failed)
    420 - gtest-tree-ntuple-v7-test-ntuple-minifile (Failed)
    423 - gtest-tree-ntuple-v7-test-ntuple-extended (Failed)
    870 - tutorial-roofit-rf612_recoverFromInvalidParameters (Failed)
    1077 - tutorial-dataframe-df006_ranges-py (Failed)
    1106 - tutorial-math-exampleFunction-py (Failed)
Errors while running CTest

For both lists the proposed change in #10308 was applied.

Expected behavior

Ideally there should be no test failures.

To Reproduce

Steps to reproduce the behaviour:

  1. build root for s390x.
  2. run the unit tests.

Setup

  1. ROOT version 6.26.02.
  2. Fedora rawhide for s390x. The list of failures is similar for other Fedora and EPEL releases.
  3. Build from source (during package build for Fedora/EPEL).

Additional context

The log

eguiraud commented 2 years ago

Assigning to Axel because I am not sure whether ROOT tries to support s390x at all.

jblomer commented 2 years ago

Regarding the RNTuple failures, one issue is the endianness (big-endian), which is addressed in #10402