[ROOT 6.29] module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20'

[iarspider]

• [x] Checked for duplicates

Describe the bug

When building CMS offline software stack with the ROOT commit 6f02c75fea, we get the following errors:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/lcg/root/6.29.01-8b1fb99c2f98c5fc80c3d3abd70c9452/etc/cling/std.modulemap:497:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20'
  module "bits/uses_allocator_args.h" {
         ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/memory_resource:42:10: note: submodule of top-level module 'std' implicitly imported here
#include    // uninitialized_construct_using_alloc
         ^

python3: /(...)/lcg/root/6.29.01-8b1fb99c2f98c5fc80c3d3abd70c9452/root-6.29.01/interpreter/llvm/src/tools/clang/lib/AST/DeclCXX.cpp:1499: clang::NamedDecl* getLambdaCallOperatorHelper(const clang::CXXRecordDecl&): Assertion `!Calls.empty() && "Missing lambda call operator!"' failed.
 *** Break *** abort

We have previously tested ROOT commit 0bd51969ce, and did not get these errors.

Expected behavior

No build errors

Setup

ROOT 6.29.01 / 6f02c75fea on AlmaLinux 8, built from source (gcc 11.2)

[davidlange6]

https://github.com/root-project/root/pull/11874 (I had seen this same error last week in cmssw while just picking up the stl.modulemap changes - I had assumed the rest of the PR would avoid this error, but seems not)

[iarspider]

@vgvassilev

[iarspider]

After updating ROOT to 026a1a701b, the first error is gone. But dictionary generation still fails due to "Missing lambda call operator". Build log: link

[iarspider]

After updating ROOT to 026a1a7, the first error is gone. But dictionary generation still fails due to "Missing lambda call operator". Build log: link

Correction: the first error is still there

[iarspider]

@Axel-Naumann gentle ping

[vgvassilev]

@iarspider, can you check if that helps: https://github.com/root-project/root/pull/12276

[iarspider]

@vgvassilev No, we still get the same errors. New build log: link.

For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30647/install.sh to create a dev area with all the needed externals and cmssw changes.

[Nowakus]

Let me add ATLAS reproducer based on the LCG dev3 Athena build:

% source /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/AtlasSetup/current/AtlasSetup/scripts/asetup.sh master--dev3LCG,latest,Athena % root root [0] new xAOD::IParticle(); /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Tue/ROOT/HEAD/x86_64-centos7-gcc11-opt/etc/cling/std.modulemap:497:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20' Break segmentation violation

Marcin

[aandvalenzuela]

Hi @vgvassilev! We were wrong, the patch works. Thanks for the fix! :) (I commented before, but I cannot see the comment anymore...)

[vgvassilev]

Hi @vgvassilev! We were wrong, the patch works. Thanks for the fix! :) (I commented before, but I cannot see the comment anymore...)

Oh, great - I was wondering what was wrong... I will revert my recent changes to the PR and merge it in...

[iarspider]

@vgvassilev just to clarify things: this did not work, but after you (and we) updated the patch, it worked.

[vgvassilev]

@iarspider both links return 0 results for me.

[davidlange6]

https://github.com/cms-sw/cmsdist/pull/8312/commits/3722765fb237aa25f434bbfa98bb2be358f1e917

[davidlange6]

is what fixed it (not obvious to me how @iarspider picked up the commit before it seems to have gotten to this pr, but ok.. maybe someones clock is wrong?

[vgvassilev]

@iarspider, can check if the issue is gone with ROOT's master now?

[aandvalenzuela]

Testing at https://github.com/cms-sw/cmsdist/pull/8320

[aandvalenzuela]

Tests just finished successfully. Thanks!

[vgvassilev]

Sounds great. I assume the lcg builds are fixed too. Let’s close this issue now. Feel free to reopen if necessary.

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[Axel-Naumann]

@vgvassilev could you backport this into v6-28-00-patches, please?

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[github-actions[bot]]

Hi @vgvassilev,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot:

[Nowakus]

Hi @vgvassilev ,
This problem crept back into both dev3 (since Mon build) and dev4 LCG nightlies. So it's both ROOT master and 6.28-patches. It can be reproduced the same way as I reported before:

% source /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/AtlasSetup/current/AtlasSetup/scripts/asetup.sh master--dev3LCG,latest,Athena % root root [0] new xAOD::IParticle(); /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Tue/ROOT/HEAD/x86_64-centos7-gcc11-opt/etc/cling/std.modulemap:554:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20' module "bits/uses_allocator_args.h" [optional] { ^ /cvmfs/sft.cern.ch/lcg/releases/gcc/11.3.0-ad0f5/x86_64-centos7/include/c++/11.3.0/memory_resource:42:10: note: submodule of top-level module 'std' implicitly imported here

include <bits/uses_allocator_args.h> // uninitialized_construct_using_alloc

Break segmentation violation

[vgvassilev]

@Nowakus thanks for the report: I am trying a fix here: https://github.com/root-project/root/pull/12752

[Axel-Naumann]

C++20 is taking a toll on us... Thanks for the fix, @vgvassilev - merged into master an v6-28-00-patches. @Nowakus could you confirm that the next nightlies look good, so I can tag v6.28/04 tomorrow?

[Axel-Naumann]

Confirmed fixed, thanks, @Nowakus @elmsheus