Closed iarspider closed 1 year ago
https://github.com/root-project/root/pull/11874 (I had seen this same error last week in cmssw while just picking up the stl.modulemap changes - I had assumed the rest of the PR would avoid this error, but seems not)
@vgvassilev
After updating ROOT to 026a1a701b, the first error is gone. But dictionary generation still fails due to "Missing lambda call operator". Build log: link
@Axel-Naumann gentle ping
@iarspider, can you check if that helps: https://github.com/root-project/root/pull/12276
@vgvassilev No, we still get the same errors. New build log: link.
For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8312/30647/install.sh to create a dev area with all the needed externals and cmssw changes.
Let me add ATLAS reproducer based on the LCG dev3 Athena build:
% source /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/AtlasSetup/current/AtlasSetup/scripts/asetup.sh master--dev3LCG,latest,Athena % root root [0] new xAOD::IParticle(); /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Tue/ROOT/HEAD/x86_64-centos7-gcc11-opt/etc/cling/std.modulemap:497:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20' Break segmentation violation
Marcin
Hi @vgvassilev! We were wrong, the patch works. Thanks for the fix! :) (I commented before, but I cannot see the comment anymore...)
Hi @vgvassilev! We were wrong, the patch works. Thanks for the fix! :) (I commented before, but I cannot see the comment anymore...)
Oh, great - I was wondering what was wrong... I will revert my recent changes to the PR and merge it in...
@iarspider both links return 0 results for me.
is what fixed it (not obvious to me how @iarspider picked up the commit before it seems to have gotten to this pr, but ok.. maybe someones clock is wrong?
@iarspider, can check if the issue is gone with ROOT's master now?
Testing at https://github.com/cms-sw/cmsdist/pull/8320
Tests just finished successfully. Thanks!
Sounds great. I assume the lcg builds are fixed too. Let’s close this issue now. Feel free to reopen if necessary.
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
@vgvassilev could you backport this into v6-28-00-patches, please?
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev,
It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.
Sincerely, :robot:
Hi @vgvassilev ,
This problem crept back into both dev3 (since Mon build) and dev4 LCG nightlies. So it's both ROOT master and 6.28-patches. It can be reproduced the same way as I reported before:
% source /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/AtlasSetup/current/AtlasSetup/scripts/asetup.sh master--dev3LCG,latest,Athena % root root [0] new xAOD::IParticle(); /cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Tue/ROOT/HEAD/x86_64-centos7-gcc11-opt/etc/cling/std.modulemap:554:10: error: module 'std.bits/uses_allocator_args.h' requires feature 'cplusplus20' module "bits/uses_allocator_args.h" [optional] { ^ /cvmfs/sft.cern.ch/lcg/releases/gcc/11.3.0-ad0f5/x86_64-centos7/include/c++/11.3.0/memory_resource:42:10: note: submodule of top-level module 'std' implicitly imported here
Break segmentation violation
@Nowakus thanks for the report: I am trying a fix here: https://github.com/root-project/root/pull/12752
C++20 is taking a toll on us... Thanks for the fix, @vgvassilev - merged into master an v6-28-00-patches. @Nowakus could you confirm that the next nightlies look good, so I can tag v6.28/04 tomorrow?
Confirmed fixed, thanks, @Nowakus @elmsheus
Describe the bug
When building CMS offline software stack with the ROOT commit 6f02c75fea, we get the following errors:
We have previously tested ROOT commit 0bd51969ce, and did not get these errors.
Expected behavior
No build errors
Setup
ROOT 6.29.01 / 6f02c75fea on AlmaLinux 8, built from source (gcc 11.2)