[ROOT-10355] Use GetDemangledTypeName instead of TypeID2TypeName

root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically

https://root.cern

Other

2.64k stars 1.26k forks source link

[ROOT-10355] Use GetDemangledTypeName instead of TypeID2TypeName #14577

Open vepadulano opened 8 months ago

vepadulano commented 8 months ago

Explain what you would like to see improved and how.

From https://its.cern.ch/jira/browse/ROOT-10355

Currently, {{RDataFrame}} uses an own implementation of getting the typename as string, namely {{ROOT::Internal::RDF::TypeID2TypeName}}. However, we could reuse {{ROOT::Internal::GetDemangledTypeName}} from ROOT core, which has the same functionality and is the superior implementation.

ROOT version

Any

Installation method

Any

Operating system

Any

Additional context

No response

aaronj0 commented 7 months ago

@vepadulano

ROOT::Internal::GetDemangledTypeName(t) calls TClassEdit::DemangleName(t.name, status)

We could also use RDFInternal::DemangleTypeIdName within the RDFInternal namespace which calls TClassEdit::DemangleTypeIDName(ti, errcode) -> TClassEdit::DemangleName(ti.name(), errcode)