search

root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically
https://root.cern
Other
2.61k stars 1.25k forks source link

ROOT generates CMake warnings when building from the tarball #15178

Closed amadio closed 1 week ago

amadio commented 4 months ago

Check duplicate issues.

Description

If you build ROOT from a tarball, you'll see the message below during configuration:

-- Found Git: /usr/bin/git (found version "2.44.0")
CMake Warning at cmake/modules/SetROOTVersion.cmake:85 (message):
  GIT_DESCRIBE_ALL is ``·with a format unexpected for tags.  Not setting the
  commit.
Call Stack (most recent call first):
  cmake/modules/SetROOTVersion.cmake:99 (SET_ROOT_VERSION)
  CMakeLists.txt:77 (include)

-- Building ROOT version 6.30.06

Not a big deal, but might be worth fixing.

Reproducer

Build ROOT from a tarball instead of a git clone.

ROOT version

ROOT 6.30.06

Installation method

Portage

Operating system

Gentoo Linux

Additional context

No response

dpiparo commented 4 months ago

Hi, what tarball did you use?

amadio commented 4 months ago

This one: https://root.cern/releases/release-63006/#source-distribution

bellenot commented 4 months ago

I can reproduce the issue. This is most probably coming from this commit @Axel-Naumann @guitargeek ?

elmsheus commented 1 month ago

We this this problem also in ATLAS AnalysisBase builds that use the source code tarball of 6.32/02 - is there a recommended work-around ?

ntadej commented 1 month ago

Probably setting GIT_DESCRIBE_ALL=tags/v6-32-02.

github-actions[bot] commented 1 week ago

Hi @bellenot,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot: