root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically
https://root.cern
Other
2.7k stars 1.28k forks source link

New CI label for nightly does not correctly report cmake configuration #15615

Closed vepadulano closed 4 months ago

vepadulano commented 5 months ago

Explain what you would like to see improved and how.

Taking as an example image

From https://github.com/root-project/root/actions/runs/9201095928/job/25318040512 . The label of the build says the build type should be debug and it should have the LLVM assertions enabled, but the configuration of the nightly job doesn't have either. One of the two should be fixed to reflect the other.

  cmake -S '/github/home/ROOT-CI/src' -B '/github/home/ROOT-CI/build' -DCMAKE_BUILD_TYPE=Release "-Dalien=off" "-Dall=off" "-Darrow=off" "-Dasan=off" "-Dasimage=on" "-Dasserts=off" "-Dbuiltin_cfitsio=off" "-Dbuiltin_clang=on" "-Dbuiltin_cling=on" "-Dbuiltin_cppzmq=on" "-Dbuiltin_davix=off" "-Dbuiltin_fftw3=off" "-Dbuiltin_freetype=off" "-Dbuiltin_ftgl=off" "-Dbuiltin_gl2ps=off" "-Dbuiltin_glew=off" "-Dbuiltin_gsl=off" "-Dbuiltin_llvm=on" "-Dbuiltin_lz4=off" "-Dbuiltin_lzma=off" "-Dbuiltin_nlohmannjson=off" "-Dbuiltin_openssl=off" "-Dbuiltin_openui5=on" "-Dbuiltin_pcre=off" "-Dbuiltin_tbb=off" "-Dbuiltin_unuran=on" "-Dbuiltin_vc=off" "-Dbuiltin_vdt=off" "-Dbuiltin_veccore=off" "-Dbuiltin_xrootd=off" "-Dbuiltin_xxhash=off" "-Dbuiltin_zeromq=on" "-Dbuiltin_zlib=off" "-Dbuiltin_zstd=off" "-Dccache=off" "-Dcefweb=off" "-Dclad=on" "-Dclingtest=off" "-Dcocoa=off" "-Dcoverage=off" "-Dcuda=off" "-Dcudnn=off" "-Dcxxmodules=off" "-Ddaos=off" "-Ddataframe=on" "-Ddavix=on" "-Ddcache=off" "-Ddev=off" "-Ddistcc=off" "-Dfail-on-missing=on" "-Dfcgi=off" "-Dfftw3=on" "-Dfitsio=on" "-Dfortran=on" "-Dgdml=on" "-Dgminimal=off" "-Dgnuinstall=off" "-Dgsl_shared=off" "-Dgviz=off" "-Dhttp=on" "-Dimt=on" "-Djemalloc=off" "-Dlibcxx=off" "-Dmacos_native=off" "-Dmathmore=on" "-Dmemory_termination=off" "-Dminimal=off" "-Dmpi=off" "-Dmysql=on" "-Dodbc=off" "-Dopengl=on" "-Dpgsql=on" "-Dpyroot=on" "-Dpythia8=off" "-Dqt5web=off" "-Dqt6web=off" "-Dr=off" "-Droofit=on" "-Droofit_multiprocess=on" "-Droot7=on" "-Drootbench=off" "-Droottest=on" "-Droottest_force_checkout=off" "-Drpath=on" "-Druntime_cxxmodules=on" "-Dshadowpw=off" "-Dshared=on" "-Dsoversion=off" "-Dspectrum=on" "-Dsqlite=on" "-Dssl=on" "-Dtcmalloc=off" "-Dtest_distrdf_dask=on" "-Dtest_distrdf_pyspark=on" "-Dtesting=on" "-Dtmva-cpu=off" "-Dtmva-gpu=off" "-Dtmva-pymva=on" "-Dtmva-rmva=off" "-Dtmva-sofie=off" "-Dtmva=on" "-Dunfold=on" "-Dunuran=on" "-During=off" "-Dvc=off" "-Dvdt=on" "-Dveccore=off" "-Dvecgeom=off" "-Dwebgui=on" "-Dwin_broken_tests=off" "-Dwinrtdebug=off" "-Dx11=on" "-Dxml=on" "-Dxrootd=on"

I do not know to how many builds this applies, I just noticed it on this one

ROOT version

Any

Installation method

Any

Operating system

Any

Additional context

No response

hahnjo commented 5 months ago

Correct, overrides are not applied for nightly builds and release binaries