search

root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically
https://root.cern
Other
2.69k stars 1.27k forks source link

Build can not recover from partial 'cleanup' #16227

Closed pcanal closed 2 months ago

pcanal commented 2 months ago

Is It 'just me' or does the master (intentionally ?) no longer re-download the tar files for the builtins. I.e.:

cmake
ninja
rm -rf *-prefix builtins
ninja

used to work and does not work anymore (and no I don't remember when was the last time I saw it worked).

bellenot commented 2 months ago

@pcanal it works for me (master on Ubuntu 20.04.6). E.g:

ubuntu@root-cmake-devel:~/build/ninja$ rm -rf *-prefix builtins
ubuntu@root-cmake-devel:~/build/ninja$ ninja
[0/1] Re-running CMake...
CMake Deprecation Warning at CMakeLists.txt:35 (cmake_policy):
  The OLD behavior for policy CMP0116 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.

-- Building ROOT version 6.33.01

...

[106/527] Performing download step (download, verify and extract) for 'BUILTIN_cppzmq'
-- Downloading...
   dst='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='http://lcgpackages.web.cern.ch/lcgpackages/tarFiles/sources/cppzmq-4.8.1.tar.gz'
-- [download 100% complete]
-- verifying file...
       file='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
-- Downloading... done
-- extracting...
     src='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
     dst='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/BUILTIN_cppzmq'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[287/527] Generating G__ROOTHist.cxx, ../../lib/ROOTHist.pcm

...

[106/527] Performing download step (download, verify and extract) for 'BUILTIN_cppzmq'
-- Downloading...
   dst='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
   timeout='none'
   inactivity timeout='none'
-- Using src='http://lcgpackages.web.cern.ch/lcgpackages/tarFiles/sources/cppzmq-4.8.1.tar.gz'
-- [download 100% complete]
-- verifying file...
       file='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
-- Downloading... done
-- extracting...
     src='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/cppzmq-4.8.1.tar.gz'
     dst='/home/ubuntu/build/ninja/builtins/zeromq/cppzmq/BUILTIN_cppzmq-prefix/src/BUILTIN_cppzmq'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[526/527] Generating lib/modules.idx

[527/527] Generating tutorials/hsimple.root

Processing hsimple.C...
hsimple   : Real Time =   0.10 seconds Cpu Time =   0.10 seconds
(TFile *) 0x562048c754d0
dpiparo commented 2 months ago

The very command

cmake
ninja
rm -rf *-prefix builtins
ninja

works also on macos14. I propose to close the issue and to rediscuss the matter after collecting more info.

pcanal commented 1 month ago

Indeed, I can't re produce it anymore either. Thanks for checking