search

root-project / root

The official repository for ROOT: analyzing, storing and visualizing big data, scientifically
https://root.cern
Other
2.67k stars 1.27k forks source link

legacy Makefiles and Configures #9090

Open ferdymercury opened 3 years ago

ferdymercury commented 3 years ago

Explain what you would like to see improved

ROOT migrated some time ago from Makefile to CMakeLists, but there are a couple of places where there are still some legacy Makefiles, check https://github.com/root-project/root/find/master:

test/Makefile
etc/Makefile.arch
config/Makefile.in
test/Makefile.win32
test/rhtml/Makefile
test/RootIDE/Makefile
test/periodic/Makefile
config/Makefile-comp.in
tutorials/tmva/makefile
test/RootShower/Makefile
test/histviewer/Makefile
test/rhtml/Makefile.win32
gui/fitpanel/test/Makefile
math/smatrix/test/Makefile
proof/doc/confman/Makefile
test/RootIDE/Makefile.win32
math/genvector/test/Makefile
test/ProofBench/Makefile_event
test/RootShower/Makefile.win32
math/mathcore/test/fit/Makefile
test/dt_Makefile
core/textinput/src/textinput/Makefile
documentation/*/Makefile
graf2d/asimage/src/libAfterImage/Makefile.in
graf2d/asimage/src/libAfterImage/configure.in

Optional: share how it could be improved

It could be done all via CMakeLists to be more homogeneous. This allows easier overview from IDEs like QtCreator that show the whole CMake subdirectories and subprojects. Moreover, it also allows to pass correctly or more easily the CMAKE_CXX_STANDARD to subprojects.

Setup

   ------------------------------------------------------------------
  | Welcome to ROOT 6.25/01                        https://root.cern |
  | (c) 1995-2021, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Jul 08 2021, 11:17:13                 |
  | From heads/master@v6-25-01-1584-g068c20d159                      |
  | With c++ (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0                     |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'       |
   ------------------------------------------------------------------

Additional context

https://github.com/root-project/root/issues/8125#issuecomment-841519742

eguiraud commented 3 years ago

Thank you @ferdymercury , @bellenot is the authoritative opinion here, but afaik I think we want this, it's just not urgent enough w.r.t. the available personpower for build system improvements.