search

root-project / rootbench

Collection of benchmarks and performance monitoring applications
GNU Lesser General Public License v2.1
20 stars 41 forks source link

Port fixes in opendata-benchmarks to rootbench #224

Closed stwunsch closed 2 years ago

stwunsch commented 3 years ago

The fixes from this PRs should be ported here: https://github.com/root-project/opendata-benchmarks/pull/11 https://github.com/root-project/opendata-benchmarks/pull/12

Note that we have to reskim the original sample, this time removing the MET_sumet branch but adding MET_pt and MET_phi.

eguiraud commented 3 years ago

Hi @stwunsch , are there other PRs (e.g. the one that fixed task 7) to be backported? Also do you think you will have time to take care of this or should I assign this to myself?

stwunsch commented 3 years ago

I've linked both PR above! I'll try to take care in the next weeks :) Performance wise, the changes should make no big difference. So porting them back is just for correctness of the code base.

eguiraud commented 2 years ago

@ikabadzhov can you please make sure the patches mentioned above are now included? it might very well already be the case

ikabadzhov commented 2 years ago

@ikabadzhov can you please make sure the patches mentioned above are now included? it might very well already be the case

Yes! Changes are applied, and that was indeed the reason why we needed to update the input files to update the branches.

eguiraud commented 2 years ago

Great, closing then.