search

root-project / rootbench

Collection of benchmarks and performance monitoring applications
GNU Lesser General Public License v2.1
19 stars 41 forks source link

Fix CI hanging at GenVector benchmark #244

Closed eguiraud closed 2 years ago

eguiraud commented 2 years ago

I am not sure exactly why, but with the empty payload of BM_Cartesian3D_Sanity google benchmark seems to enter an infinite loop here: https://github.com/google/benchmark/blob/d0fbf8ac238d3bc3a111334ab3553173812d78e7/src/benchmark_runner.cc#L280-L303

In principle gbench should exit the loop after a certain maximum number of iterations, but it doesn't seem to happen, or for some reason it takes way too much time.

In any case, as this benchmark is actually just a hack to inject a sanity check, we might as well set it to run only 1 iteration.

oshadura commented 2 years ago

Wow! Nice investigation! (and thanks a lot for debugging timeout!) maybe it could be interesting to report this behavior as a googlebench git issue?

oshadura commented 2 years ago

I will merge to see if it helps in #242 PR