search

root-project / rootbench

Collection of benchmarks and performance monitoring applications
GNU Lesser General Public License v2.1
19 stars 41 forks source link

Fix Errors in RDataFrameOpenDataBenchmarks #248

Closed ikabadzhov closed 2 years ago

ikabadzhov commented 2 years ago

All errors and warnings of RDataFrameOpenDataBenchmarks (introduced in #242) are now cleared.

ikabadzhov commented 2 years ago

@oshadura on the length of the tasks: if run on 1 file, they should be relatively quick (not more than 30 minutes for all on 1 core). Only benchmark 6 is slightly longer. I am attaching reference running times from ntpl-perf01: O3CMPvsJIT

eguiraud commented 2 years ago

@oshadura I guess the CI does not run with -Drootbench-dataset=ON so these benchmarks are not compiled?

oshadura commented 2 years ago

@oshadura I guess the CI does not run with -Drootbench-dataset=ON so these benchmarks are not compiled?

Yes, it makes sense now...