root-systems / cobuy

:seedling: :package: :stew: :family: Helping people buy good food at good prices, together.
GNU Affero General Public License v3.0
25 stars 4 forks source link

dynamic structured data in profile #152

Open ahdinosaur opened 7 years ago

ahdinosaur commented 7 years ago

this way, users can update a person or group profile to contain anything they wish:

without needing us to develop special support for these types of profile information.

~this ticket is to update the Profile component to use a wysiwyg editor, which will save the "description" property as either html or markdown, which will be rendered as such when viewing. note: we must sanitize user input here, to protect against cross-site scripting attacks if we allow malicious html or markdown.~

danalexilewis commented 7 years ago

Could we use a similar system to what we were doing for follow the sun where people create fields?

Going this way will we be able to extract info like address for invoices?

ahdinosaur commented 7 years ago

Going this way will we be able to extract info like address for invoices?

good point. was hoping this would reduce scope for MVP.

Could we use a similar system to what we were doing for follow the sun where people create fields?

yes. we probably should give this some thought.

danalexilewis commented 7 years ago

++ for reducing scope -- for adding significant technical debt ;) if this is cheap to change later maybe a wysiwyg - so long as the wysiwyg is a quick implantation.

Good thinking!

ahdinosaur commented 7 years ago

my thoughts on a structured profile data approach:

then while creating an invoice, you would choose which address and phone number is appropriate.

ahdinosaur commented 7 years ago

also this came up in https://github.com/root-systems/cobuy/pull/140,

looked at adding more fields to the Profile for a Person, but decided in consultation with @ahdinosaur that it'd be good to have deliberate design on which fields make sense before developing

ahdinosaur commented 7 years ago

maybe https://github.com/sstur/react-rte to edit and save markdown?

Julietbc commented 7 years ago

after doing some initial work to integrate this and it becoming overly complicated I have discussed with @iainkirkpatrick and decided, for now(late oct demo), to just add some new fields for email, address etc rather than a full on wysiwyg editor

ahdinosaur commented 7 years ago

hey @Julietbc , what did you find complicated about the wysiwyg editor?

iainkirkpatrick commented 7 years ago

gonna whack this back into backlog cause the ticket as per the description wasn't completed, instead the alternative (and we aren't counting points or anything ;) )