root-systems / cobuy

:seedling: :package: :stew: :family: Helping people buy good food at good prices, together.
GNU Affero General Public License v3.0
25 stars 4 forks source link

improve group management form/page #472

Closed gregorykan closed 6 years ago

gregorykan commented 6 years ago

consider alongside #347

gregorykan commented 6 years ago

@ahdinosaur @agentlewis what are the requirements for this page?

gregorykan commented 6 years ago

no fixed requirements, with focus on improvements.

see #93

iainkirkpatrick commented 6 years ago

@gregorykan did you speak to @ahdinosaur @agentlewis ? are there no specific needs that this ticket is designed to address then? if so, i'd question if this ticket is necessary for the first deadline - if this is just a case of 'generally improve things'

gregorykan commented 6 years ago

@iainkirkpatrick understood! adding a couple of obvious things that would be worth implementing/correcting

danalexilewis commented 6 years ago

Yes as a feature this is not of high importance from my point of view - more something Greg indicated was causing general pain. Ie delivering this feature would solve some pain.

Note the remove doesn’t work once someone has been added - only for staging invites.

iainkirkpatrick commented 6 years ago

ok that helps clarify @gregorykan @agentlewis thanks :) incidentally i think the reason rows take ages to reappear is cause we do a bunch of feathers service fetches after submitting... it's a case of optimising re-querying i think.

gregorykan commented 6 years ago

thanks @agentlewis ! then we will restrict the scope of this ~ i think the two points i added should be resolvable without too much cost

danalexilewis commented 6 years ago

@iainkirkpatrick alternatively we delay optimising such things in favour of a spinner showing its thinking.

Than we could look at something like redux offline in dogstack