Closed gregorykan closed 6 years ago
cool just ripped through a test of this - clicking on things in the app. all seems to work, the main comment I have is that some of the positioning atm doesn't work very well - seems that some components are positioned off of the bottom of the page? i.e. the save profile button, the list of groups... at least on my laptop this causes big overlaps unless I zoom way out. reckon these probably need fixing, by having the components flow from top to bottom..? i'll try find an example and point it out with a review comment
apart from that everything seems to work :)
oh one thing we can always fix later - to me it's confusing to have both the groups i belong to and the suppliers of those groups accessed from the same menu item. i wonder if suppliers are better accessed by going through groups first? or having their own menu item? or being shown adjacent to the groups they supply to... hmm ideas.
yeah the positioning changes if i turn off flex: 1
from containers around the save button, group list etc. something like that
@iainkirkpatrick as discussed, gonna create another ticket for this as i can't figure this out now!
closes #457 closes #458