search

root-two / react-native-drawer

React Native Drawer
MIT License
2.54k stars 390 forks source link

fix to work with React 16.0 #304

Closed sean-macfarlane closed 7 years ago

sean-macfarlane commented 7 years ago

Changed PropTypes it use the correct package import PropTypes from 'prop-types'; Works with React 16.0

sean-macfarlane commented 7 years ago

@rt2zz

rt2zz commented 7 years ago

@sean-macfarlane thanks, I believe prop-types needs to be added to package.json as well?

jnbt commented 7 years ago

@sean-macfarlane May you add the following change to package.json to your PR:

"dependencies": {
  "tween-functions": "^1.0.1"
  "prop-types": "^15.5.8"
}
sean-macfarlane commented 7 years ago

sorry about the delay, I have added the dependency as requested.

altagir commented 7 years ago

when is this committed? is the main repo dead? alternatively how to use your branch? thanks

sean-macfarlane commented 7 years ago

@altagir if you can't wait for the PR to be merged, and want to use my branch, you can do so by changing your package.json to use my branch:

"dependencies": {
   "react-native-drawer": "git+https://github.com/sean-macfarlane/react-native-drawer.git",
}

or install the package by doing npm install https://github.com/sean-macfarlane/react-native-drawer.git

sebandres commented 7 years ago

@rt2zz Thanks for merging!

Any chance of publishing a 2.3.1 or 2.4.0 with this change?

Cheers!