root670 / CheatDevicePS2

Game enhancer for PlayStation 2 similar to Action Replay, GameShark, and CodeBreaker. (No longer in development)
GNU General Public License v3.0
79 stars 18 forks source link

Value-mapped cheats incompatibility with 4-type codes #54

Closed re-bug closed 1 year ago

re-bug commented 1 year ago

The $ sign for value-mapped cheats is picked up as a comment, breaking 4-type cheats as well as 32-bit increment/decrement cheats, as one of their code lines begins with a value.

Codes of other types that make use of value-mapped cheats work correctly.

Example code:

"Kinetica (SCUS-97132)" enable code 901ACF94 0C07076B

[weight] 40000000=2/275 41F00000=30/275 42F00000=120/275 43AF0000=350/275 442F0000=700/275 44BB8000=1500/275

vehicle weight 40780BC0 000900BF $weight 00000000

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete as much of the following information as possible):

If there is a character that forces the software to pick a comment-like line as a code line, I didn't see it in the wiki.

root670 commented 1 year ago

Value maps only work for what is typically the "value" portion of a code (the last 8 digits that follow the 8 digit address). The parsing code would need to be refactored to support multi-line codes where the typical "address" portion (first 8 digits) contains a value map reference.

re-bug commented 1 year ago

Oh, well, guess it's time to adapt the cheat then. Anyways, thanks for responding.