search

rootCircle / codemark-cli

CLI app for Codemark for HOF v4.0
https://devfolio.co/projects/codemark-251c
Apache License 2.0
6 stars 5 forks source link

Add support for environment variables #11

Closed Kota-Karthik closed 8 months ago

Kota-Karthik commented 8 months ago

I have added all the variables of secrets.py into .env and added .env to gitignore and also removed secrets.py from .env

rootCircle commented 8 months ago

LGTM :+1: Let me test on my machine!

rootCircle commented 8 months ago

Hi @Kota-Karthik, Tested it out! It's working great!

Just few suggestions,

  1. Add dotenv library to pyproject.toml (poetry add python-dotenv)
  2. FIREBASE_STORAGE_BUCKET and FIREBASE_STORAGE_BUCKET_URL seems redundant, please remove one!
  3. Please reflect updated installation steps in docs.
rootCircle commented 8 months ago

Solves #11

rootCircle commented 8 months ago

LGTM :+1: Merged! Thanks for your contribution!