Closed Gyan172004 closed 1 year ago
Congratulations on your second PR to this project! :partying_face: I personally like the well documented changes you had put through, in this pull request.
I am currently not considering filler.js changes as that deemed unnecessary to this code, and for else I will test and review the extractor's code very soon and get back on it soon
You have done a really great job! KUDOS
I did some initial testing!
Here are some of my suggestions
other
option should be segregated from the code. You can use this case independently for MULTIPLE_CHOICE_WITH_OTHER than MULTIPLE_CHOICE and put keys as options and other receptively or any other appropriate name you like. [Same with CheckBox ]Thank you for your valuable feedback! Segregating the "Other" option in multiple-choice and checkbox sections will improve the user experience significantly. Separating lower and upper bounds in the Linear Scale will enhance usability. I'll work on these suggestions promptly.
Your contributions are highly valued, and I'm eager to collaborate further to create a more robust solution. I'll keep you updated on the progress. Thank you for your support!
I've implemented your suggestions, segregating the "Other" option in Multiple Choice with Other
and Multiple Correct with Other
and separating lower and upper bounds in Linear Scale.
It made the code more robust and will enhance the user experience.
Please take a moment to review the updates, and if you have any further suggestions or thoughts, I am eager to hear them. :)
I have tested new changes @Gyan172004 and your PR looks very promising, I am merging it for now.
I had reviewed your code, and found brute-forced function in getOptions_GRID() method but that's acceptable for now! We might change that later!
Congrats!! :smile:
Summary:
This pull request introduces enhancements to the FieldsExtractorEngine to improve the extraction of options for different field types. The code has been refactored and detailed comments have been added to explain the logic and extraction process more effectively.
Changes Made:
getOptions_MULTI_CORRECT:
getOptions_MULTIPLE_CHOICE:
getOptions_LINEAR_SCALE:
getOptions_GRID:
Description:
These changes aim to enhance the existing functionality of FieldsExtractorEngine, making it more versatile and accurate in extracting options for different types of questions. The detailed comments will help developers understand the logic and implementation of each method better.
Please review and merge the pull request after examining the changes. Let me know if any further improvements are needed.