rootCircle / docFiller

Automated Google Docs Filling Web Extension written in JS
GNU General Public License v3.0
10 stars 14 forks source link

Extract DOM objects and option data for all question types #15

Closed Gyan172004 closed 1 year ago

Gyan172004 commented 1 year ago

This commit adds functionality to extract DOM objects and option data for all types of questions that have options.

The function now correctly retrieves the DOM elements and their corresponding option data for dropdowns , MultiCorrect , Checkboxes , MultiCorrect With Other , Multiple Choice , Multiple Choice With Other , Multiple Choice Grid , and Linear Scale. .

The commit also includes improvements to handle cases where questions do not have any options, returning an empty array in such cases.

Gyan172004 commented 1 year ago

This commit implements functions to retrieve DOM objects for input fields in various non-option question types.

These question types include Text, Paragraph, Text Email, Text Numeric, Text Telephonic, Text URL, Date, Date And Time, Time, Duration, Date without Year, Date without Year with Time, Date with Time and Meridiem, Time and Meridiem, and Date without Year with Time and Meridiem.

With this implementation and all previous work, all necessary information for all question types (options, options with other, and non-option) has been extracted.

🚀 The extractor work appears to be complete, pending any further issues.

rootCircle commented 1 year ago

Congrats for the third feat!! :boom:

Again you did some terrific work!!! I appreciate the amount of effort and hard work that goes through them and will be glad to see more of them in future. Well done @Gyan172004

I have done some changes from my side, basically function renaming to accord with JS camelCase convention and some design changes etc. I hope you find them ok!

I have preliminary reviewed your code and find it suitable to be put to the main code-base, however the actual code might require some code changes after refactoring in probable future, as review was not not strong probably due to high demand regarding this from filler engine.

rootCircle commented 1 year ago

I am merging your code for now, as it might be required extensively in filler engine in near future! Yay :confetti_ball:

Great work!!