search

rooteco / tweetscape-streams

3 stars 3 forks source link

User (Twitter account) matching key #63

Open kikuomax opened 1 year ago

kikuomax commented 1 year ago

When upserting users (Twitter accounts) on the graph database, do we have any specific reason to use username instead of id as a key?

https://github.com/rooteco/tweetscape-streams/blob/c2644efdd03c451360e33f25a87eed2e5882c331/app/models/streams.server.ts#L523

ntorba commented 1 year ago

@kikuomax Thanks for pointing this out. This was a bad design decision and we should update it to user id.

One example of a problem this causes: duplicate users if a user updates their @username (i ran into that this morning actually...)

Another important place to update this is in the db seed when we set constraints: https://github.com/rooteco/tweetscape-streams/blob/f183ff9bd35f830411acd3684962a798e940b0be/neo4j/seed.ts#L51