rootiest / zippy-klipper_config

Zippy Klipper Config
GNU General Public License v3.0
391 stars 46 forks source link

[FEATURE] #13

Closed DaVinci-10 closed 7 months ago

DaVinci-10 commented 1 year ago

Is your feature request related to a problem?Add [smart_effector] support to get_probe_limits macro A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] I use the [smart_effector] in my printer.cfg, when running this it errored out on get_probe_limits

10:40:01 $ GET_PROBE_LIMITS
10:40:01 echo: Failed to detect probe in configfile

So I added the following in the macro.

{% elif config["smart_effector"] %}
# smart_effector probe section found
{% set probe = config["smart_effector"] %}
{% set has_probe = True %}

And it then functioned properly.

10:41:46 $ GET_PROBE_LIMITS
10:41:46 echo: Configured Probe X-Offset -5.00
10:41:46 echo: Configured Probe Y-Offset 0.00
10:41:46 echo: Configured Probe Z-Offset -0.1
10:41:46 echo: Minimum PROBE position X=-9.0 Y=-5.0
10:41:46 echo: Maximum PROBE position X=228.125 Y=212.125

Describe the solution you'd like A clear and concise description of what you want to happen. I am not familiar with adding this via pulls or anything, but found it useful. And wanted to let you know somehow or another. So forgive if would be better another meathod.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. I can use the [probe] definition on my system, but prefer [smart_effector] as it lets me set probe move acceleration It would be handy to see other output related to the [smart_effector] features, but not required for the fix.

Additional context Add any other context or screenshots about the feature request here.

Checklist

github-actions[bot] commented 1 year ago

Welcome DaVinci-10!\nCongrats on creating your first issue.\nPlease follow the issue template to help us resolve your issue quickly.

rootiest commented 7 months ago

Hey @DaVinci-10 this is a great idea!

I will go ahead and merge in your suggested changes, thank you for the suggestion!

rootiest commented 7 months ago

Added in the following commit:

https://github.com/rootiest/zippy-klipper_config/commit/f8d7998904504120151bbfff5510cad19d2e31f7

Thanks @DaVinci-10 !