pep8speaks
commented
4 years ago Hello @rontav! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
rootio/radio/views.py:
Line 26:80: E501 line too long (90 > 79 characters) Line 54:80: E501 line too long (127 > 79 characters) Line 54:127: E502 the backslash is redundant between brackets Line 55:13: E128 continuation line under-indented for visual indent Line 58:80: E501 line too long (82 > 79 characters) Line 68:80: E501 line too long (83 > 79 characters) Line 70:80: E501 line too long (112 > 79 characters) Line 70:112: E502 the backslash is redundant between brackets Line 71:9: E128 continuation line under-indented for visual indent
- In the file
rootio/utils.py:
Line 227:52: E251 unexpected spaces around keyword / parameter equals Line 227:54: E251 unexpected spaces around keyword / parameter equals
Improved loading time for /radio page by merging analytics SQL queries into a single one that is parallelised by PostgreSQL. On our machines, we've seen ~3x pageload time speedups.