search

rootless-containers / bypass4netns

[Experimental] Accelerates slirp4netns using SECCOMP_IOCTL_NOTIF_ADDFD. As fast as `--net=host`.
https://medium.com/nttlabs/accelerating-rootless-container-network-29d0e908dda4
Apache License 2.0
131 stars 6 forks source link

nerdctl integration #12

Closed naoki9911 closed 2 years ago

AkihiroSuda commented 2 years ago

Looks good but a couple of nits, thank you!

AkihiroSuda commented 2 years ago

"netnsd" accidentally looks like a typo of "netbsd", lol 😆

I think this is fine for now, but we may want to renaming it in future if somebody complains

naoki9911 commented 2 years ago

Thanks for your comments! I improved the code as you mentioned.

"netnsd" accidentally looks like a typo of "netbsd"

I completely agree with you. Giving an appropriate shortened name is a very difficult task😆