Closed AkihiroSuda closed 6 years ago
updated PR, PTAL
LGTM. Thanks @AkihiroSuda! I will get to work implementing support for this in umoci
.
Whats the license of pb portion? AGPL? CC?
Since it's a spec, I would recommend putting it under Apache 2.0 (though since you wrote it, it's up to you). AGPL doesn't really apply to this at the moment (I added that when I was planning on writing my own webserver for it using Flask rather than just using Hugo) and so the text is CC-BY-SA 4.0 -- but we can make the Protobuf Apache 2.0 so that it's usable for most projects (including GPLv3 projects).
(Though I would argue that the Protobuf is not significant enough (nor is it actually a program) that a license on it would actually be valid.)
Updated the PR
LGTM. Will merge this in a bit.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
ref: https://github.com/AkihiroSuda/runrootless/pull/2#issuecomment-356217514