search

rootless-containers / slirp4netns

User-mode networking for unprivileged network namespaces
GNU General Public License v2.0
745 stars 83 forks source link

CI: Test with libslirp 4.3.1 on CentOS 7 #236

Closed mbargull closed 3 years ago

mbargull commented 3 years ago

This is a followup to https://github.com/rootless-containers/slirp4netns/pull/234#discussion_r523735247 :

@mbargull in https://github.com/rootless-containers/slirp4netns/pull/234#discussion_r523735247 :

I did not investigate this further, so can't tell if it's kernel or ncat version related, but with libslirp 4.3.1 the --disable-dns did not show the expected timeout.

@AkihiroSuda in https://github.com/rootless-containers/slirp4netns/pull/234#discussion_r523911136 :

timeout of what?

@mbargull in https://github.com/rootless-containers/slirp4netns/pull/234#discussion_r523984433 :

https://github.com/rootless-containers/slirp4netns/blob/v1.1.6/tests/test-slirp4netns-disable-dns.sh#L33-L35 does not get a timeout message to grep for (the ncat seems to succeed).

@AkihiroSuda, I don't know if you'd want to investigate this further. I'm just opening this here for demonstrative purposes. Feel free to amend or close!

AkihiroSuda commented 3 years ago

Thanks, this seems to require investigation

AkihiroSuda commented 3 years ago

The test may work after rebasing with master, which contains https://github.com/rootless-containers/slirp4netns/commit/a7d99afa92f86e5c5a89cf20afd5a32d739fc0c8

mbargull commented 3 years ago

The test may work after rebasing with master, which contains a7d99af

IIRC, I tested it locally with that commit too and the ncat simply succeeded without outputting any timeout -- but it makes sense to rebase in any case!

AkihiroSuda commented 3 years ago

Vagrant itself uses 10.0.2.0/24, so it conflicts with slirp4netns 😭

AkihiroSuda commented 3 years ago

Being fixed in https://github.com/rootless-containers/slirp4netns/pull/240

mbargull commented 3 years ago

Oh dear, I doubt I would've noticed that as quickly as you did :D. Thanks, superseded by gh-240.