search

rootless-containers / slirp4netns

User-mode networking for unprivileged network namespaces
GNU General Public License v2.0
729 stars 82 forks source link

Explicitly support DHCP + add tests+ update libslirp to v4.6.1 #270

Closed AkihiroSuda closed 3 years ago

AkihiroSuda commented 3 years ago

Close #124

The test should pass with libslirp < 4.6.0 and libslirp >= 4.6.1, but should fail with libslirp == 4.6.0 .

https://gitlab.freedesktop.org/slirp/libslirp/-/issues/48

AkihiroSuda commented 3 years ago

@giuseppe WDYT? Not really useful for containers, but this has been implemented since the beginning.

Also, as a side-effect, slirp4netns-test-dhcp.sh might be useful for testing libslirp itself.

giuseppe commented 3 years ago

LGTM