search

rootless-containers / usernetes

Kubernetes without the root privileges
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2033-kubelet-in-userns-aka-rootless
Apache License 2.0
853 stars 58 forks source link

`make kubeadm-join` shouldn't print token to the console #299

Closed AkihiroSuda closed 9 months ago

AkihiroSuda commented 10 months ago

https://github.com/rootless-containers/usernetes/blob/57a770aba7a9421ebe7324b8025d60633bb20efc/Makefile#L96-L97

$(shell cat join-command) contains token values and should not be printed to the console, as users may submit the console output for asking questions or report bugs.

Maybe, make kubeadm-init shouldn't print token too (kubeadm init --skip-token-print) https://github.com/rootless-containers/usernetes/blob/57a770aba7a9421ebe7324b8025d60633bb20efc/Makefile#L91-L93