rootpd / go-binance

Go wrapper for Binance API
MIT License
33 stars 121 forks source link

json tag 't' used twice in same structure #7

Open gpmn opened 5 years ago

gpmn commented 5 years ago

https://github.com/rootpd/go-binance/blob/c656b55bcff406ed07451fbf5b0ac99f7397ac8b/service_websocket.go#L344

tag 't' used twice in same structure.

./service_websocket.go:344: struct field TakerCommision repeats json tag "t" also at ./service_websocket.go:342

according to https://github.com/binance-exchange/binance-official-api-docs/blob/master/user-data-stream_CN.md

            rawAccount := struct {
                Type string  `json:"e"`
                Time float64 `json:"E"`

// remove this -> //OpenTime float64 json:"t" MakerCommision int64 json:"m" TakerCommision int64 json:"t" BuyerCommision int64 json:"b" SellerCommision int64 json:"s" CanTrade bool json:"T" CanWithdraw bool json:"W" CanDeposit bool json:"D" Uptime float64 json:"u" // <------------ add this Balances []struct {

filinvadim commented 4 years ago

I support this repo here: https://github.com/filinvadim/go-binance