search

rootpd / nette-sentry

Nette Sentry logger extension
9 stars 9 forks source link

PHP User Deprecated: Nette\Http\Session::getIterator() #13

Open martenb opened 1 year ago

martenb commented 1 year ago

See https://github.com/nette/http/releases/tag/v3.2.1

martenb commented 1 year ago

https://github.com/rootpd/nette-sentry/blob/master/src/SentryLogger.php#L136

martenb commented 1 year ago

Inspiration here https://github.com/contributte/sentry/commit/964cbc2a8c7977445dc82562d19318897050a39a

rootpd commented 1 year ago

Hi @martenb , I am aware of this. I already handled this in 2.0.0 (specifically https://github.com/rootpd/nette-sentry/commit/ad301dc2f963275281e57dd486f3facf97442423), but in a different session.

The original approach tracked everything, that Nette session contained, including some internals. I believe that deprecation of Session iterator was implemented exactly because we shouldn't touch/read those internals and only track/log the sessions sections that application is aware of.

Because of that, I'd stick with the implementation introduced in 2.0.0 using explicitly configured session sections.

It wouldn't make sense to copy contributte package anyway, there's no need to have two libraries which work the same way :).

martenb commented 1 year ago

Makes sense, didn't noticed v2. Thx for info.