search

rootpy / WebOOT

A ROOT viewer for the web
Other
11 stars 6 forks source link

Eclipse PyDev code analysis complaints #120

Open cdeil opened 11 years ago

cdeil commented 11 years ago

This is for current master ( 96559b5fbeec2fa0c80f28ba499d0185b2dad868 ).

Here's the full list: https://gist.github.com/cdeil/5329994

I only list the ones that might be real / relevant here. Some (or most / all) might not make sense, I didn't look in detail. @pwaller Feel free to simply close this issue if you think it doesn't make sense.

Description Resource    Path    Location    Type
Method '__getitem__ - utils.root_vfs' should have self as first parameter   root_vfs.py /WebOOT/weboot/utils    line 529    PyDev Problem
Undefined variable from import: from_parent tree.py /WebOOT/weboot/resources/root   line 96 PyDev Problem
Undefined variable: axes    histogram.py    /WebOOT/weboot/resources/root   line 133    PyDev Problem
Undefined variable: basename    baskets.py  /WebOOT/weboot/resources    line 21 PyDev Problem
Undefined variable: fnmatch baskets.py  /WebOOT/weboot/resources    line 104    PyDev Problem
Undefined variable: fixup_hist_units    combination.py  /WebOOT/weboot/resources    line 249    PyDev Problem
Undefined variable: fixup_hist_units    combination.py  /WebOOT/weboot/resources    line 431    PyDev Problem
Undefined variable: render_canvas   multitraverse.py    /WebOOT/weboot/views    line 201    PyDev Problem
Undefined variable: HTTPMethodNotAllowed    histogram.py    /WebOOT/weboot/resources/root   line 133    PyDev Problem
Undefined variable: re  baskets.py  /WebOOT/weboot/resources    line 104    PyDev Problem
Undefined variable: pjoin   baskets.py  /WebOOT/weboot/resources    line 51 PyDev Problem
Undefined variable: RootObject  tobjarray.py    /WebOOT/weboot/resources/root   line 30 PyDev Problem
Undefined variable: HTTPFound   file.py /WebOOT/weboot/resources/root   line 70 PyDev Problem
Undefined variable: TObjArrayTraverser  file.py /WebOOT/weboot/resources/root   line 98 PyDev Problem
Undefined variable: subpath baskets.py  /WebOOT/weboot/resources    line 107    PyDev Problem
Undefined variable: listdir baskets.py  /WebOOT/weboot/resources    line 106    PyDev Problem
Undefined variable: subpath baskets.py  /WebOOT/weboot/resources    line 104    PyDev Problem
Undefined variable: HTTPMethodNotAllowed    file.py /WebOOT/weboot/resources/root   line 65 PyDev Problem
Undefined variable: resource_path   file.py /WebOOT/weboot/resources/root   line 68 PyDev Problem
Undefined variable: log object.py   /WebOOT/weboot/resources/root   line 72 PyDev Problem
Undefined variable: HTTPFound   shibboleth.py   /WebOOT/weboot  line 26 PyDev Problem

Description Resource    Path    Location    Type
Import redefinition: Combination    multitraverser.py   /WebOOT/weboot/resources    line 83 PyDev Problem
Import redefinition: Combination    multitraverser.py   /WebOOT/weboot/resources    line 52 PyDev Problem

Description Resource    Path    Location    Type
Unused import: re   file.py /WebOOT/weboot/resources/root   line 5  PyDev Problem
Unused import: traverse file.py /WebOOT/weboot/resources/root   line 7  PyDev Problem
Unused import: exists   vfs.py  /WebOOT/weboot/resources    line 3  PyDev Problem
Unused import: isdir    vfs.py  /WebOOT/weboot/resources    line 3  PyDev Problem
Unused import: pjoin    file.py /WebOOT/weboot/resources/root   line 2  PyDev Problem
Unused import: exists   file.py /WebOOT/weboot/resources/root   line 2  PyDev Problem
Unused import: isdir    file.py /WebOOT/weboot/resources/root   line 2  PyDev Problem
Unused import: isfile   file.py /WebOOT/weboot/resources/root   line 2  PyDev Problem
Unused import: isfile   vfs.py  /WebOOT/weboot/resources    line 3  PyDev Problem
Unused import: W_OK user.py /WebOOT/weboot/resources    line 0  PyDev Problem
Unused import: traverse vfs.py  /WebOOT/weboot/resources    line 8  PyDev Problem
Unused import: listdir  vfs.py  /WebOOT/weboot/resources    line 2  PyDev Problem
Unused import: re   vfs.py  /WebOOT/weboot/resources    line 6  PyDev Problem
Unused import: timer    object.py   /WebOOT/weboot/views/root   line 8  PyDev Problem
Unused variable: date   auto_mongo.py   /WebOOT/weboot  line 46 PyDev Problem
Unused import: PIPE renderable.py   /WebOOT/weboot/resources    line 6  PyDev Problem
Unused import: fnmatch  file.py /WebOOT/weboot/resources/root   line 4  PyDev Problem
Unused import: RootObject   file.py /WebOOT/weboot/resources/root   line 16 PyDev Problem
Unused variable: name   combination.py  /WebOOT/weboot/resources    line 566    PyDev Problem
Unused variable: params combination.py  /WebOOT/weboot/resources    line 445    PyDev Problem
Unused variable: i  multitraverser.py   /WebOOT/weboot/resources    line 445    PyDev Problem
Unused import: LocationAware    histogram.py    /WebOOT/weboot/resources/root   line 12 PyDev Problem
Unused variable: tf root_vfs.py /WebOOT/weboot/utils    line 398    PyDev Problem
Unused variable: params combination.py  /WebOOT/weboot/resources    line 472    PyDev Problem
Unused import: dump root_vfs.py /WebOOT/weboot/utils    line 515    PyDev Problem
Unused variable: ymin   combination.py  /WebOOT/weboot/resources    line 211    PyDev Problem
Unused variable: rp root_vfs.py /WebOOT/weboot/utils    line 225    PyDev Problem
Unused import: R    ttree.py    /WebOOT/weboot/resources/root   line 2  PyDev Problem
Unused import: Renderable   static.py   /WebOOT/weboot/resources    line 6  PyDev Problem
Unused variable: n  combination.py  /WebOOT/weboot/resources    line 584    PyDev Problem
Unused import: kTeal    combination.py  /WebOOT/weboot/resources    line 285    PyDev Problem
Unused import: kSpring  combination.py  /WebOOT/weboot/resources    line 285    PyDev Problem
Unused variable: n  combination.py  /WebOOT/weboot/resources    line 571    PyDev Problem
Unused variable: params combination.py  /WebOOT/weboot/resources    line 487    PyDev Problem
Unused variable: ymax   combination.py  /WebOOT/weboot/resources    line 211    PyDev Problem
Unused import: build_draw_params    combination.py  /WebOOT/weboot/resources    line 198    PyDev Problem
Unused import: resource_path    baskets.py  /WebOOT/weboot/resources    line 1  PyDev Problem
Unused import: static_url   multitraverser.py   /WebOOT/weboot/resources    line 12 PyDev Problem
Unused variable: e  breadcrumb.py   /WebOOT/weboot/views    line 12 PyDev Problem
Unused import: keepalive    canvas.py   /WebOOT/weboot/resources/root   line 1  PyDev Problem
Unused variable: things baskets.py  /WebOOT/weboot/resources    line 101    PyDev Problem
Unused import: time breadcrumb.py   /WebOOT/weboot/views    line 2  PyDev Problem
Unused variable: i  multitraverser.py   /WebOOT/weboot/resources    line 307    PyDev Problem
Unused import: Renderable   multitraverser.py   /WebOOT/weboot/resources    line 21 PyDev Problem
Unused import: Histogram    multitraverser.py   /WebOOT/weboot/resources    line 51 PyDev Problem
Unused import: HTTPNotFound multitraverser.py   /WebOOT/weboot/resources    line 8  PyDev Problem
Unused variable: n  multitraverser.py   /WebOOT/weboot/resources    line 426    PyDev Problem
Unused variable: y  multitraverser.py   /WebOOT/weboot/resources    line 204    PyDev Problem
Unused import: Combination  multitraverser.py   /WebOOT/weboot/resources    line 83 PyDev Problem
Unused variable: drawn  tree.py /WebOOT/weboot/resources/root   line 82 PyDev Problem
Unused import: re   filesystem.py   /WebOOT/weboot/resources    line 4  PyDev Problem
Unused variable: i  multitraverser.py   /WebOOT/weboot/resources    line 452    PyDev Problem
Unused import: R    baskets.py  /WebOOT/weboot/resources    line 4  PyDev Problem
Unused import: Histogram    multitraverser.py   /WebOOT/weboot/resources    line 82 PyDev Problem
Unused import: Combination  multitraverser.py   /WebOOT/weboot/resources    line 52 PyDev Problem
Unused import: groupby  multitraverser.py   /WebOOT/weboot/resources    line 5  PyDev Problem
Unused import: fnmatch  filesystem.py   /WebOOT/weboot/resources    line 3  PyDev Problem
Unused variable: i  multitraverse.py    /WebOOT/weboot/views    line 83 PyDev Problem
Unused import: unwrap   actions.py  /WebOOT/weboot/resources    line 60 PyDev Problem
Unused variable: name   multitraverse.py    /WebOOT/weboot/views    line 200    PyDev Problem
Unused variable: name   multitraverse.py    /WebOOT/weboot/views    line 206    PyDev Problem
Unused import: pformat  multitraverse.py    /WebOOT/weboot/views    line 3  PyDev Problem
Unused import: HasActions   home.py /WebOOT/weboot/resources    line 8  PyDev Problem
Unused import: fnmatch  vfs.py  /WebOOT/weboot/resources    line 5  PyDev Problem
Unused import: wraps    actions.py  /WebOOT/weboot/resources    line 60 PyDev Problem
Unused variable: i  multitraverse.py    /WebOOT/weboot/views    line 102    PyDev Problem
Unused import: LocationAware    actions.py  /WebOOT/weboot/resources    line 172    PyDev Problem
Unused import: traverse filesystem.py   /WebOOT/weboot/resources    line 6  PyDev Problem
Unused import: R    vfs.py  /WebOOT/weboot/resources    line 13 PyDev Problem
``
pwaller commented 11 years ago

I think I would feel more comfortable doing this once we have some (basic) functional tests. Do you mind if we close this "not fixed" and revisit it in the future?

cdeil commented 11 years ago

I'd prefer labelling it "later" and keeping it open ... we'll never remember to look through closed tickets.