search

roots-id / rootswallet

An open source identity/credential wallet built for grass roots efforts in multiple countries.
https://www.rootswallet.com
Apache License 2.0
18 stars 1 forks source link

Add Wallet to Wallet connections #107

Closed rodolfomiranda closed 2 years ago

AlexAndrei98 commented 2 years ago

when running yarn install I get "https://npm.pkg.github.com/download/@input-output-hk/atala-prism-sdk/1.4.1/675695ebf288d0459c90c8598930973c5bfd6e12: Request failed \"401 Unauthorized\"". despite my env var credentials being set up

rodolfomiranda commented 2 years ago

I did not change anything regarding prism sdk. The error is clear, by the way. But I think that @2byrds removed JS sdk dependencies from the code. Try removing @input-output-hk/atala-prism-sdk": "^1.4.1" from package.json

2byrds commented 2 years ago

I did not change anything regarding prism sdk. The error is clear, by the way. But I think that @2byrds removed JS sdk dependencies from the code. Try removing @input-output-hk/atala-prism-sdk": "^1.4.1" from package.json

great point! likely it's been taken down and removing it should be good... i don't recall where i removed it before, maybe this branch.... checking now will report back soon :)

2byrds commented 2 years ago

I had removed it here https://github.com/roots-id/rootswallet/pull/110

rodolfomiranda commented 2 years ago

I had removed it here #110

So I added without intention in my PR :)

2byrds commented 2 years ago

I had removed it here #110

So I added without intention in my PR :)

I think you still have it in your branch, can you rebase with main. if you take the PR out of draft i think it will tell you to rebase first. https://github.com/roots-id/rootswallet/blob/106-wallet-to-wallet-connections/package.json#L24

2byrds commented 2 years ago

I had removed it here #110

So I added without intention in my PR :)

I think you still have it in your branch, can you rebase with main. if you take the PR out of draft i think it will tell you to rebase first. https://github.com/roots-id/rootswallet/blob/106-wallet-to-wallet-connections/package.json#L24

i updated via the github editor, pretty great tool! i'll test it now. try updating @AlexAndrei98 for your testing.

2byrds commented 2 years ago

I was unable to use the cameras from my emulator https://github.com/roots-id/rootswallet/issues/113. But @rodolfomiranda has a video he can include on this PR and @AlexAndrei98 confirmed it worked for him.