search

roots / acorn

Laravel components for WordPress plugins and themes
https://roots.io/acorn/
MIT License
824 stars 94 forks source link

Request validation and signature macros are missing #409

Open stefanfisk opened 1 month ago

stefanfisk commented 1 month ago

Version

4.2.2

What did you expect to happen?

I expected the request validation and signature macros to be added.

What actually happens?

They are not.

I think that we need just need to copy FoundationServiceProvider::registerRequestValidation() and FoundationServiceProvider::registerRequestSignatureValidation().

AFAICT the functions work as expected as long as the macros are added.

Steps to reproduce

Try calling $request->validate().

System info

No response

Log output

No response

Please confirm this isn't a support request.

Yes

stefanfisk commented 1 month ago

I can create a PR. Should they go in AcornServiceProvider?

QWp6t commented 1 month ago

Yeah, that would be awesome. Thanks @stefanfisk 🙂