search

roots / bedrock

WordPress boilerplate with Composer, easier configuration, and an improved folder structure
https://roots.io/bedrock/
MIT License
6.15k stars 1.16k forks source link

Display correct bedrock-autoloader version #728

Closed chrillep closed 1 month ago

chrillep commented 2 months ago

https://github.com/roots/bedrock/blob/8df74d1dfdd60953db939ac7cbd3d134310aa863/composer.lock#L342-L343

Maybe there is a better way of fetching version from lockfile or adding it to roots/bedrock-autoloader per default. But until then...

tangrufus commented 2 months ago

Or, we can just remove the Version line from plugin header.

chrillep commented 2 months ago

Or, we can just remove the Version line from plugin header.

i just happend to stumble upon this when i was looking for something else. :) Do whatever is simplest to maintain. ❤️

retlehs commented 2 months ago

Good idea @tangrufus :+1:

@chrillep Are you not open to iterating on this PR after receiving feedback? If so, just close it.

chrillep commented 1 month ago

Good idea @tangrufus 👍

@chrillep Are you not open to iterating on this PR after receiving feedback? If so, just close it.

sorry went on vacation.

I removed the Version line from plugin header.