roots / bud

High-performance build system that supports SWC, esbuild, and Babel
https://bud.js.org/
MIT License
339 stars 38 forks source link

[repo] can't upgrade to @yarnpkg/builder@^4.0.0 #2415

Open kellymears opened 1 year ago

kellymears commented 1 year ago

Agreement

Describe the issue

Repo cli (@bud) is a yarn plugin but the build fails using version 4.0.0 of @yarnpkg/builder.

Expected Behavior

After installing @yarnpkg/builder@4.0.0 running yarn install will build the @bud cli

Actual Behavior

The @bud cli build process fails.

Steps To Reproduce

  1. Run yarn upgrade-interactive.
  2. Select @yarnpkg/builder (4.0.0-rc-46 -> 4.0.0)

version

0.0.0

Logs

Usage Error: This plugin cannot access the package referenced via node:fs which is neither a builtin, nor an exposed entry (when initializing @yarnpkg/plugin-bud, defined in /Users/kellymears/code/git/roots/bud/.yarnrc.yml)

Configuration

No response

Relevant .budfiles

No response

kellymears commented 1 year ago

If I replace the node:* with the non namespaced equivalents manually, it works. I think @yarnpkg/builder might need to include node:* as externals.

kellymears commented 1 year ago

I patched it with an esbuild plugin, which should do for now.

kellymears commented 10 months ago

Updated the patch in #2527