search

roots / sage-installer

Sage 9 installer
https://github.com/roots/sage
MIT License
30 stars 85 forks source link

Invalid scss in bulma preset #31

Closed Johannestegner closed 3 years ago

Johannestegner commented 5 years ago

The bulma preset have a include in the _wp-classes.scss which is invalid in SCSS. I suspect that node-sass accepts it and will compile it correctly, while the recommended package sass (dart implementation) is more strict and will throw an error upon reaching this line.

The following is the line:

https://github.com/roots/sage-installer/blob/60c329d6f5d750f78804b9577f2944c05b3a24dc/src/Presets/stubs/Bulma/styles/components/_wp-classes.scss#L26

The +tablet() sass call is equal to (when using scss) @include tablet(), changing to this will allow dart-sass to compile the code successfully.

mmirus commented 5 years ago

Thanks for reporting!

Log1x commented 5 years ago

Not even sure node-sass would've compiled this without it being a .sass extension. I wish @jgthms would refactor Bulma's codebase.

jgthms commented 5 years ago

I’m not responsible for this Bulma. It has nothing to do with my CSS framework.

Log1x commented 5 years ago

@jgthms – it has nothing to do with this include. I meant more-so in general, an organized SCSS rewrite would be nice and I'd imagine more maintainable. Either way, sorry to highlight you. Wasn't meant to be taken out of context.