roots / sage

WordPress starter theme with Laravel Blade components and templates, Tailwind CSS, and a modern development workflow
https://roots.io/sage/
MIT License
12.74k stars 3.06k forks source link

Docs incorrect for correct deployment for Sage9 #1967

Closed jvgeee closed 7 years ago

jvgeee commented 7 years ago

Submit a feature request or bug report


What is the current behavior?

The docs mention running gulp to build for production, while the readme says to run yarn build:production. Neither build anything that can be zipped up and installed in a WP site - docs should be clearer on how to actually deploy here!

What is the expected or desired behavior?

A /dist/ folder that can be zipped and installed in a Wordpress site, or at least instructions on how to make on.

The folder structure that the Sage install process creates is also very different from a regular Wordpress theme folder (no PHP files in the root directory...) and the build process gives an error that The package could not be installed. The theme is missing the style.css stylesheet..

retlehs commented 7 years ago

sage 9 docs don't mention gulp. sage 9 readme links to the sage 9 docs

https://github.com/roots/sage#documentation

jvgeee commented 7 years ago

Yes, which link to https://github.com/roots/docs/blob/sage-9/sage/theme-deployment.md, which link to this post from 2 years ago: http://austinpray.com/ops/2015/01/15/build-steps-and-deployment.html

And regardless, the specific mention of gulp vs yarn isn't the issue here - it's the the instructions don't properly explain how to deploy a theme to wordpress at all. How do I get my files into a format that can actually be installed in Wordpress?

retlehs commented 7 years ago

please don't use github for support...