search

roots / sage

WordPress starter theme with Laravel Blade components and templates, Tailwind CSS, and a modern development workflow
https://roots.io/sage/
MIT License
12.75k stars 3.06k forks source link

Replace the yarn pot command by the one recommended in the docs #3095

Closed bonakor closed 1 year ago

bonakor commented 2 years ago

The yarn command was not able to really create a complete pot file. Most strings from the Blade templates were missing. With this command, it seems to be working as it should be.

I found the command in the docs https://docs.roots.io/sage/10.x/localization/#generating-language-files

I removed the previous command to avoid any misunderstanding.

retlehs commented 2 years ago

See #3081, which I think we can merge now that WP-CLI released a new version

cc @strarsis

strarsis commented 2 years ago

Yes, using wp i18n instead eliminates the need for extra tools and also adds proper Blade-PHP parsing.

The current release of wp i18n has some bugs though. There had been no new release with the bug fixes yet. But one can install the latest wp i18n that works properly by using wp cli update --nightly. This may be mentioned in the documentation until wp i18n has a new stable release.

bonakor commented 2 years ago

Sorry, I didn't realize https://github.com/roots/sage/pull/3081 fixed it already. While wp-cli team handles the remaining bug, should this PR be merged as it has the working solution proposed in the docs? Or are the docs enough?