🔧 Acorn v3 (Laravel 9.x), drop PHP 7.4 support

roots / sage

WordPress starter theme with Laravel Blade components and templates, Tailwind CSS, and a modern development workflow

https://roots.io/sage/

MIT License

12.71k stars 3.06k forks source link

🔧 Acorn v3 (Laravel 9.x), drop PHP 7.4 support #3097

Closed retlehs closed 1 year ago

retlehs commented 1 year ago

These changes are required to upgrade to Acorn v3

TODOs

[x] Acorn v3 stable release
[x] Upgrade docs (https://github.com/roots/docs/issues/433)

Ref https://github.com/roots/acorn/releases

Striffly commented 1 year ago

Any update for this ? Some dependencies (like php-ffmpeg) seems to not be compatible with roots/acorn v2 :

Fatal error: Declaration of Illuminate\Container\Container::has($id) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool in /app/vendor/illuminate/container/Container.php on line 194

Upgrading to roots/acorn v3 seems to resolve this issue, but we can't show any view for the moment...

retlehs commented 1 year ago

Upgrading to roots/acorn v3 seems to resolve this issue, but we can't show any view for the moment..

What update are you looking for? This PR demonstrates how to correctly upgrade to Acorn v3 and doesn't contain the error that you're describing. It's not going to be merged until Acorn v3 has a stable release.

Striffly commented 1 year ago

After upgrading, I got this error too : Target class [sage.view] does not exist.

Log1x commented 1 year ago

After upgrading, I got this error too : Target class [sage.view] does not exist.

Double check your ThemeServiceProvider making sure it extends SageServiceProvider and has parent:: calls to register() and boot() if they are present. You can reference my latest commit.