Bug: Writing to a non-writable environment

travisanderson99 commented 1 year ago

Terms

[X] I have read the guidelines for Contributing to Roots Projects
[X] This request is not a duplicate of an existing issue
[X] I have read the docs and followed them (if applicable)
[X] I have seached the Roots Discourse for answers and followed them (if applicable)
[X] This is not a personal support request that should be posted on the Roots Discourse community

Description

What's wrong?

We have recently migrated to Wordpress VIP (https://wpvip.com) for our host, and they have a read-only platform. Sage attempts to create directories in certain cases, which throws the following error:

Read-only file system in /chroot/var/www/wp-content/themes/mytheme/vendor/illuminate/filesystem/Filesystem.php

This is the block of code where the error is occurring:

    public function makeDirectory($path, $mode = 0755, $recursive = false, $force = false)
    {
        if ($force) {
            return @mkdir($path, $mode, $recursive);
        }

        return mkdir($path, $mode, $recursive);
    }

Possible solutions

Checking to see if the directory is writable would avoid this issue on non-writable systems such as ours.

Temporary workarounds

The site still functions as expected using the Sage theme, but these warnings are being thrown on every request.

Steps To Reproduce

Visit any site within our multisite network such as https://www.prepredzone.com, which will trigger the error internally.

Expected Behavior

Ideally, the filesystem would only attempt to create the directory if the directory is writable or can be written to.

Actual Behavior

An error is generated when the directory is attempted to be created.

Relevant Log Output

No response

Versions

10.0.3

retlehs commented 1 year ago

Hi @travisanderson99! We use our forum for support requests, not GitHub issues. The code block that you highlighted comes from our dependencies and isn't something that we can modify.

I think this is the first we've heard of an issue with WP VIP, but the solution to this problem should be similar to how folks are deploying Sage 10 sites with Pantheon (search our forum for more info).

Furthermore, since you're a WP VIP customer and paying for their services, I'd suggest first reaching out to their support folks to see if they've already got an answer for you. They can also reach out to us directly if they have any questions.

travisanderson99 commented 1 year ago

Hi Ben, thanks for the reply. I realized after I created this ticket last night that the Illuminate/Filesystem package isn't something you manage.

I was able to fork that repository and modify the function that attempts to write to a directory and then pass that updated package to composer. That seems to have resolved the issue.

roots / sage