roots / sage

WordPress starter theme with Laravel Blade components and templates, Tailwind CSS, and a modern development workflow
https://roots.io/sage/
MIT License
12.77k stars 3.06k forks source link

🎨 Move default theme markup to the `app` layout #3167

Closed Log1x closed 10 months ago

Log1x commented 11 months ago

After testing with Debug Bar, it appears that moving the default theme markup to the app layout does not have any negative side-effects like before seen with Sage 9 (e.g. #2116). Another pair of eyes to confirm would be cool.

Alongside being cleaner to maintain this stuff in Blade, this also fixes a lot of inconsistencies/rendering issues with Acorn's exception handler.

Change log

jeremylind commented 7 months ago

I think wp_head() needs to be called in index.php outside the app context in order to properly enqueue scripts. In my testing, with a block with block.json defining a view script, the script is not enqueued when wp_head() is in the app layout.