search

roots / sage

WordPress starter theme with Laravel Blade components and templates, Tailwind CSS, and a modern development workflow
https://roots.io/sage/
MIT License
12.69k stars 3.06k forks source link

Seems eslint --fix doesn't apply prettier changes #3170

Closed cawa-93 closed 8 months ago

cawa-93 commented 8 months ago

Version

10.7.0

What did you expect to happen?

I applied the linters and formatting configuration to the project as specified in the documentation.

However, I notice something strange. In the .prettierrc: is "semi": true. However, when I run the eslintonconsole.log('')`, it does not show errors in this place and does not correct the syntax.

What actually happens?

Eslint ignore semicolon rule.

Steps to reproduce

  1. Clone Sage repo
  2. Follow the documentation and add lintets into project.
  3. Install eslint by yarn add eslint -D.
  4. Open resources/scripts/editor.js and remove all semicolons.
  5. Run lint yarn run lint:js

System info

No response

Log output

No response

Please confirm this isn't a support request.

Yes

retlehs commented 8 months ago

Please use https://discourse.roots.io/ for support requests

Also take a look at https://bud.js.org/extensions/bud-eslint if you're looking for the config for having ESLint fix errors