roots / trellis-cli

A CLI to manage Trellis projects
https://roots.io/trellis/
MIT License
167 stars 25 forks source link

[bug] trellis alias causing bud build to throw warning #397

Closed chrillep closed 1 year ago

chrillep commented 1 year ago

Version

latest

What did you expect to happen?

aliases to be correct

What actually happens?

yarn build yarn run v1.22.19 $ yarn bud build production [fs] [wp-cli.trellis-alias.yml] › ⚠ wp-cli.trellis-alias.yml causes an exception when read. Since wp-cli.trellis-alias.yml does not appear to be a bud configuration file, bud.js is not throwing. Original error follows:

BudError: end of the stream or a document separator is expected (1:1)

1 | @development: -----^

Steps to reproduce

run trellis aliases run yarn build

System info

great system

Log output

[fs] [wp-cli.trellis-alias.yml] › ⚠  wp-cli.trellis-alias.yml causes an exception when read.
Since wp-cli.trellis-alias.yml does not appear to be a bud configuration file, bud.js is not throwing. Original error follows:

BudError: end of the stream or a document separator is expected (1:1)

 1 | @development:
-----^

Please confirm this isn't a support request.

Yes

relates to: https://github.com/roots/bud/issues/2332

chrillep commented 1 year ago

if this belongs in radicle and or bud whatnot please keep this for reference and add the correct ticket there

swalkinshaw commented 1 year ago

You cross-posted so I'll wait for @kellymears to chime in. Right now I have no how Bud integrates with this WP-CLI config.

chrillep commented 1 year ago

You cross-posted so I'll wait for @kellymears to chime in. Right now I have no how Bud integrates with this WP-CLI config.

yeah i couldnt help myself :) just thought it was interconnected so both repo/users should know

chrillep commented 1 year ago

https://github.com/roots/bud/issues/2332#issuecomment-1605024519

swalkinshaw commented 1 year ago

Closing this since it's just a Bud issue. It seems weird that Bud would load any random yml file in a project root and error if its not valid...

chrillep commented 1 year ago

yeah, from my standpoint i just want the warning gone :) .

for now i have to to quote the strings, so other teammates dont start to wonder what im doing. :)

Cause aliases are quality of life, but hard to get this into a standard in out repos if bud is logging warnings..