This PR changes the recently added stderr exemption of a specific PHP warning from the WP CLI wp core is-installed command for multisite sites to the DB error dump that occurs with not yet set up multisite sites.
This eliminates the need for letting the WP CLI require a temporary PHP file with constants that disable the multisite feature, which itself caused fatal PHP errors in recent WordPress/Bedrock/Trellis setups where those multisite constants where redefined in the Bedrock application config.
Initial deployment of multisite sites will successfully complete and allow finalization of the site setup (by using the WP CLI, web GUI setup process, importing a database dump/transfer uploads/data files, etc).
As an improvement the Trellis Multisite documentation could be updated so that it includes the web GUI URL for the site setup (if someone prefers or needs that over the WP CLI approach): http://<a canonical host or domain_current_site>/wp/wp-admin/install.php as frontend request redirection to the setup web GUI page may not work until the site setup is completed.
This PR changes the recently added
stderrexemption of a specific PHP warning from the WP CLIwp core is-installedcommand for multisite sites to the DB error dump that occurs with not yet set up multisite sites.This eliminates the need for letting the WP CLI require a temporary PHP file with constants that disable the multisite feature, which itself caused fatal PHP errors in recent WordPress/Bedrock/Trellis setups where those multisite constants where redefined in the Bedrock application config.
Initial deployment of multisite sites will successfully complete and allow finalization of the site setup (by using the WP CLI, web GUI setup process, importing a database dump/transfer uploads/data files, etc).
http://<a canonical host or domain_current_site>/wp/wp-admin/install.phpas frontend request redirection to the setup web GUI page may not work until the site setup is completed.Should Ansible clean up an existing(added: https://github.com/roots/trellis/pull/1391/files#diff-da02775cb0a887a7b8c5f5183fffe57a8840d53f47065f919dff77ad2accd4a0R2-R6)tmp_multisite_constants.phpfile? It would be useless anyway and its purpose become forgotten on existing Trellis systems.