Conditionally add HTTPS inbound allow firewall rule

roots / trellis

WordPress LEMP stack with PHP 8.2, Composer, WP-CLI and more

https://roots.io/trellis/

MIT License

2.51k stars 607 forks source link

Conditionally add HTTPS inbound allow firewall rule #1530

Closed strarsis closed 3 months ago

strarsis commented 3 months ago

This PR lets the firewall rule to allow inbound HTTPS to be added conditionally. Only when at least one site uses HTTPS, the firewall rule for allowing inbound HTTPS is added.

strarsis commented 3 months ago

Edit: Using the delete attribute as this allows toggling and proper clean up of file when HTTPS firewall allow rule is not needed (in subsequent provisions), it also allows for much simpler configuration code. The not inverts the fact that SSL is used, as it is used with delete which does the opposite of enabling the rule.

swalkinshaw commented 3 months ago

Thanks @strarsis