search

roots / wordpress

Automatically updated WordPress Composer package
https://roots.io/composer-wordpress-resources/
MIT License
171 stars 15 forks source link

Use official dist file #5

Closed LeoColomb closed 5 years ago

LeoColomb commented 5 years ago

This is a proposal to use official dist archive from https://wordpress.org/download/releases/

I'm sure there are better way to do this, but may require a small refactoring.

Fix #3 (and prepare https://github.com/roots/wordpress/projects/1#card-15623591)

Note that we may also use the "official" git repo git://core.git.wordpress.org/ (ref), that said tags don't follow WordPress versioning style, so...

LeoColomb commented 5 years ago

Done. 🙂

LeoColomb commented 5 years ago

Any chance for a review before 5.1.1 release tag? 😉 🚀

austinpray commented 5 years ago

Oh sorry for leaving you hanging. I've been thinking about this change and honestly it would have to go in a fork to avoid backwards compat breakage. Everyone that comes from the johnp/wordpress package expects us to use the git repo mirror as a source. Swapping over to the wp.org source would be pulling the rug out from some people.

I think it definitely would be a useful thing for us to maintain with very little overhead required. I'm thinking maybe fork to roots/package-wordpress-org? @roots/everyone whatcha think?

Also 5.1.1 is already released.

LeoColomb commented 5 years ago

Also 5.1.1 is already released.

Just few hours after my comment 😆

The difference (wp.org over github repo) is the following:

A wp-content/plugins/akismet/*
D wp-content/themes/twentyeleven/*
D wp-content/themes/twentyfifteen/*
D wp-content/themes/twentyfourteen/*
D wp-content/themes/twentyten/*
D wp-content/themes/twentythirteen/*
D wp-content/themes/twentytwelve/*
LeoColomb commented 5 years ago

Closing in favor of https://github.com/roots/wordpress-packager

austinpray commented 5 years ago

We’ll get that rolling soon!

swalkinshaw commented 2 years ago

@LeoColomb 2+ years later I think we should go forward with this. Do you want to open a new PR with these changes again? I'll give you a day or two before we do it.

LeoColomb commented 2 years ago

@swalkinshaw Oh wow! 😃 Well, yes for sure, but against this very repo or on https://github.com/roots/wordpress-packager? As it was planned to take over with more flexibility...

Also I ended to extend these builds via a dedicated org. I just enabled https://github.com/composer-wordpress/full to match the zipball suggested on this PR (I prefer to use https://github.com/composer-wordpress/no-content for my projects, way lighter).

LeoColomb commented 2 years ago

@swalkinshaw I did my best to respond within the allotted two days, I would appreciate an acknowledgement 🙂

Again, if maintaining this stuff is too much time consuming (which is the case, I think), feel free to switch to https://github.com/composer-wordpress/full or https://github.com/composer-wordpress/no-content. I've done this with strict enforcement of metadata, and enough automation to ensure long-term updates. Even the beta/RC are available.

swalkinshaw commented 2 years ago

@LeoColomb yeah I'm really sorry about that. I even said I was a jerk for ignoring this in our Roots Slack 😞

It's been on my list and then we were talking about this internally. Here's the conclusion we came to:

Starting with WordPress 6.0, we'll make a breaking change to adopt make roots/wordpress the no-content distribution of WP and recommend that people use the wpackagist-theme packages if they want any of the themes. We were hesistant to make the breaking change before but ultimately it's the right thing to do in the long run.

We can still offer the "full" variant as well like you have.

Thank you so much for https://github.com/roots/wordpress-packager/pull/406. I'm travelling this weekend but I'll prioritize it as the next Roots thing I do.

LeoColomb commented 2 years ago

@swalkinshaw No worries, all is fine 🙂

That said, the internal discussions you mentioned are a huge part of the frustration. This is/was not the first contribution I have submitted to Roots projects which is closed or left uncommented with clearly "in-the-dark" discussions (same for the ones made by others, of course). This breaks the contract between contributors and maintainers, especially when you maintainers are not 100% focused on Roots projects (for valid reasons). This leaves contributors with arbitrary decisions.

Starting with WordPress 6.0, we'll make a breaking change to adopt make roots/wordpress the no-content

Ok; good to know!

I'm travelling this weekend but I'll prioritize it as the next Roots thing I do.

Looking forward to your review! (but no rush, if it's not next week I'll survive 😊)

swalkinshaw commented 2 years ago

@LeoColomb fair point, and yes we should handle these situations better.

I've just created https://github.com/roots/wordpress/issues/32 to bring some visibility to our plan.