rootsdev / genscrape

JavaScript library that aids in scraping person data off of genealogy websites
MIT License
42 stars 6 forks source link

Person/birthDate from Open Archives not processed #38

Closed coret closed 7 years ago

coret commented 7 years ago

While testing with WikiTree X and RootsSearch I noticed that the Person/birthDate value isn't recognized/handled. The scraper is similar tot the Genealogie Online scraper which does handle the person/birthDate value. Microdata on both sites are the same (and valid).

Test page: [https://www.openarch.nl/show.php?archive=srt&identifier=4d23eb16-04c8-c35d-e0c0-8504b2342a22&200&lang=en]()

coret commented 7 years ago

Researched the issue. In case of the example, the first person on the page is taken (other Sourcetype), this person doesn't have a birthDate. To fix, more sourcetypes should be recognized.

The current processBaptism function basically looks for parents and the 'main' person. This is the same for births ("BS Geboorte") and deaths ("BS Overlijden").

The sourcetype "DTB Trouwen" should be handled like "BS Huwelijk".