search

rootstrap / active-storage-base64

Base64 support for ActiveStorage
https://rootstrap.com
MIT License
160 stars 16 forks source link

Rails 5.2.2.1 not yet supported #26

Closed nick-adams closed 5 years ago

nick-adams commented 5 years ago

I've been using this gem and it's working great. Thanks for all your work on it!

However, I did recently try to upgrade Rails (there was a security release 3/13: https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/) but Bundler threw an error because this gem has a hard dependency on <= 5.2.2

  In Gemfile:
    rails (~> 5.2.2.1)

    active_storage_base64 was resolved to 0.1.3, which depends on
      rails (~> 5.2.0, <= 5.2.2)

I just wanted to bring this to your attention and see if there was a plan or preference on how to update things to allow for this upgrade.

Disclaimer: I am not a seasoned Rails developer, so I don't know the exact protocol on things like this. I wanted to reach out before submitting a PR that just bumped the Rails dependency in the gemspec in fear of other consequences. I could certainly do that though if that's the recommendation.

archonic commented 5 years ago

Seems like this should just be rails (~> 5.2).

archonic commented 5 years ago

Fixed this in #27

skcc321 commented 5 years ago

Thank for the fix. When do you expect to release the change?

archonic commented 5 years ago

That's up to @rootstrap, I don't own the original repo.

You could use the patch with gem "active_storage_base64", github: "archonic/active-storage-base64" in your Gemfile.

Edit: I just noticed this organization has 0 public members, so I can't @mention a human :/

Ricoch commented 5 years ago

Hello there, thanks for posting the issue. Just some insight into why we limited to these versions of Rails. At the moment of the creation of this gem, the current maximum rails version was 5.2.2, and we knew that in their master branch they were working on some changes that were not compatible at all with the gem in it's current version. We didn't know at that point wether those changes were going to be for the next version (which was 5.2.2.1) or if they were going to come on Rails 6 (which seems to be the case), therefore we decided to lock the versions up to 5.2.2. Thanks for noticing!

Ricoch commented 5 years ago

We'll be working on the upload of a new version of the gem with this change soon. Regards

santib commented 5 years ago

Hey @archonic @nick-adams sorry for the long time, I just released v0.1.4 of the gem that works with rails ~> 5.2

There are some changes needed to support Rails 6, you are more than welcome to open a PR if you want.