search

rootstrap / active-storage-base64

Base64 support for ActiveStorage
https://rootstrap.com
MIT License
161 stars 16 forks source link

Variants support #69

Closed santib closed 2 years ago

santib commented 2 years ago

Fixes #68

It also drops support for Rails 6.1 since the API is different. I think this is fine since Rails 6.1 users can continue to use v1.2.0 of the gem. Otherwise, if we want to keep support, we'll need to maintain 2 dummy apps for the specs (one for Rails 6.1 and another one for Rails 7.0).

santib commented 2 years ago

Code LGTM. I think the main discussion is to decide the jump from 1.2.x to 2.0.x. I'm ok with it but this will split the maintenance of the gem in two active versions. How much time do we expect to maintain 6.x support? will 1.2.x branch only receive security fixes and no new features or we expect to backport them? Also haven't checked if we're still supporting other versions below 1.2.

Yes, I think it would be worth adding a versions table to the README. Regarding support I'm ok fixing bugs for Rails 5 versions on 0.x, bugs for Rails 6 on 1.x and bugs for Rails 7 on 2.x. This gem is pretty small and tightly coupled to ActiveStorage so we usually don't get bug reports