rootstrap / android-base

Rootstrap Android Base project
https://rootstrap.com
40 stars 6 forks source link

About pre-commit hook #46

Open sfiamene opened 3 years ago

sfiamene commented 3 years ago

Could someone please share your thoughts about why this was implemented this way?

We faced that when we add a new commit to a branch we end up with all the code modified and sometimes the changes that we added are deleted. This can be prevented by adding the flag --no-verify when commiting but it makes no sense to have a tool configured and then avoid using it on purpose.

Other findings were that the steps ktlintFormat and ktkint when excecuted separately doesn't make any modifications to the code, so the issue could be made by the stash commands.

I'd like to open a discuss here about how to improve this